Skip to content

[MV3] Dart debug extension supports DWDS versions < 17.0.0 #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 11, 2023
Merged

[MV3] Dart debug extension supports DWDS versions < 17.0.0 #1882

merged 6 commits into from
Jan 11, 2023

Conversation

elliette
Copy link
Contributor

We are now relying on DebugInfo being sent along with the dart-app-ready event. This will be included as part of the 17.0.0 of DWDS.

For backwards compatibility with older versions of DWDS, this PR adds the ability to read the DebugInfo directly off of the Window object instead if it's missing from the dart-app-ready event.

@elliette elliette requested a review from annagrin January 10, 2023 21:41
annagrin
annagrin reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test this?

@elliette
Copy link
Contributor Author

Can we test this?

We can't currently test this because we are always testing everything against DWDS master, and this is only needed for older versions of DWDS. I think it will require a fair amount of work to get testing for this change, including splitting the debug extension out of DWDS, and not depending on DWDS test infrastructure to run out tests.

@elliette
Copy link
Contributor Author

Can we test this?

We can't currently test this because we are always testing everything against DWDS master, and this is only needed for older versions of DWDS. I think it will require a fair amount of work to get testing for this change, including splitting the debug extension out of DWDS, and not depending on DWDS test infrastructure to run out tests.

Actually, figured out how to add a simple test!

annagrin
annagrin approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit e134e5b into dart-lang:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@annagrin annagrin annagrin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @annagrin